http - nginx server name regex when "Host" header has a trailing dot -


i've considered potential trailing hostname dot handling in 2 contexts in nginx, , curious whether usage in either 1 necessary entirely correct configuration:

  • server_name ~^(\w+)\.(example\.com)\.?$;

  • if ($host ~ ^(\w*)\.(example\.com)\.?$) {

no, not necessary in either context — nginx automatically takes care of trailing dot, both in context of $host variable, server_name directive, leaving $http_host variable dot (if present in request).

i believe implemented in http/ngx_http_request.c#ngx_http_validate_host:

1925    if (dot_pos == host_len - 1) { 1926        host_len--; 1927    }

it can verified following minimal config:

server {     listen  [::]:7325;     server_name ~^(\w*)\.?(example\.com\.?)$;     return  200 c:$2\th:$host\thh:$http_host\tsn:$server_name\n; }

running following tests against nginx/1.2.1:

%printf 'get / http/1.0\nhost: head.example.com.\n\n' | nc localhost 7325 | fgrep example c:example.com   h:head.example.com  hh:head.example.com.    sn:~^(\w*)\.?(example\.com\.?)$ % %printf 'get http://line.example.com./ http/1.0\n\n' | nc localhost 7325 | fgrep example c:example.com   h:line.example.com  hh: sn:~^(\w*)\.?(example\.com\.?)$ % %printf 'get http://line.example.com./ http/1.0\nhost: head.example.com.\n\n' | nc localhost 7325 | fgrep example c:example.com   h:line.example.com  hh:head.example.com.    sn:~^(\w*)\.?(example\.com\.?)$ %

note neither regexp capture within server_name directive, nor $host variable, ever has trailing dot. such, pointless account in above contexts.


Comments

Post a Comment

Popular posts from this blog

php - Vagrant up error - Uncaught Reflection Exception: Class DOMDocument does not exist -

i've set bento/ubuntu-16.04 vagrant box using php 5.6, , getting following error quite few times when try , run shell script: "uncaught reflection exception: class domdocument not exist". i've tried adding following top of script (not together), each no success: "sudo apt-get install php5.6-xml", "sudo apt-get install php5-xml", "sudo apt-get install php-dom" i've tried resetting server "sudo service apache2 restart". does have suggestions?
Read more

vue.js - Create hooks for automated testing -

Image
qa guys complained can't automate frontend testing. because our html looks same outside. lazy hack did this <template> <div :role="$options.name"> ... </div> </template> <script> export default { name: 'vmcomponentname' } </script> which takes name script , applies html. in browser get: <div role="vmcomponentname"> ... </div> line :role="$options.name" goes in every component. is there dry er solutions? please share. additional details i'll explain in details looking for. imagine have vmusercreate form creates user. test case can create user . to automatically test without role, have use following selector: .wrapper > .wrapper > .wrapper > .submit-button the test extremely brittle (will break lot). if use roles can use [role="vmusercreateform"] .submit-button selector. many folds less brittle. so basically, i'm ...
Read more

Add new key value to json node in java -

i have json file : { "id":1, "name":"abc", "addressdetails": { "city":"newyork" } } i wanted add 1 more key-value ("pincode" : "414141") node 'addressdetails'. i tried using : objectmapper mapper = new objectmapper(); jsonnode root = mapper.readtree(new file("d://test.json")); objectnode node = mapper.createobjectnode(); node.with("addressdetails").put("pincode", "414141"); but it's not getting added, there way can ? you can try you should modify file path objectmapper mapper = new objectmapper(); objectnode nodes = mapper.readvalue(new file("d:\\test.txt"), objectnode.class); nodes.with("addressdetails").put("pincode", "414141"); mapper.writer().writevalue(new file("d:\\test.txt"), nodes);
Read more